fix(lsp): timeout write to prevent hang when LSP server stdin is full#16114
Open
JayZenith wants to merge 1 commit intoanomalyco:devfrom
Open
fix(lsp): timeout write to prevent hang when LSP server stdin is full#16114JayZenith wants to merge 1 commit intoanomalyco:devfrom
JayZenith wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16115
Type of change
What does this PR do?
After a large patch, pyright saturates the CPU and stops reading its stdin. The pipe buffer fills and the next write in LSP.touchFile blocks indefinitely, freezing the UI completely.
Wraps the write in withTimeout(3s) so we move on if the LSP isn't responsive.
How did you verify your code works?
20 iterations of large patch and immediate whitespace follow-up against the exact file that triggered the original hang. Zero freezes, zero timeouts.
Screenshots / recordings
N/A
Checklist